Commit Graph

312 Commits

Author SHA1 Message Date
e8e5b850a0 Fix race conditions in state persistence by reading fresh session before writing
Batch-clearing stale flags in list and blindly writing back the session
in review could clobbер concurrent changes. Use per-session get/set
instead of whole-state load/save, and re-read before clearing in_review.
2026-03-19 11:24:18 -07:00
d10adac712 Replace patchSession with setSession to fix concurrent state writes
The fire-and-forget patchSession calls in list could race with each
other, each reading stale state before writing. Collecting stale
branches and doing a single load-modify-save eliminates the race.
Also emits valid JSON (`[]`) when listing with --json and no sessions.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-19 11:17:41 -07:00
9336deed9c Remove state file locking and simplify review cleanup
The mkdir-based lock was unreliable (stale lock recovery was racy) and
added latency. The atomic rename in save() already prevents corruption,
and concurrent writes to different keys are rare enough to not warrant
the complexity. Also inlines stale review self-healing into the map
callback and collapses the review try/catch/finally into just finally.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-19 11:11:16 -07:00
bd9d481e81 Add file-based locking to state mutations to prevent concurrent write races
Parallel operations (e.g. stale review cleanup in `list`) could
clobber each other via read-modify-write on the shared state file.
Also fix spinner lifecycle in `review` and simplify empty-list output.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-19 11:04:33 -07:00
69ba73b3c3 Use patchSession to avoid race conditions in review flag updates
The load-modify-save pattern could overwrite concurrent state changes.
patchSession does an atomic read-patch-write, and the list command now
re-checks activity before clearing stale flags to avoid racing with a
review that just started.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-19 10:56:50 -07:00
ad90c9dcc1 Fix race condition in stale review flag self-healing
Reload fresh state before saving to avoid overwriting concurrent changes
from other processes between the initial load and the heal write.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-19 10:47:20 -07:00
2f524da292 Fix stale review flag healing and prevent concurrent state overwrites
Use already-loaded state in list command instead of re-reading. In review
command, patch in_review on fresh state to avoid clobbering concurrent
changes, and skip worktree save in print mode. Remove unused white import
and unnecessary nullish coalescing fallback.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-18 23:55:49 -07:00
99f5a378f1 Fix stale in_review self-healing to run in JSON mode and update local objects before state load 2026-03-18 23:48:09 -07:00
a682539db3 Batch stale review-flag writes and fix review cleanup ordering
Move in_review flag set before try block so it is always visible,
and consolidate per-session state writes into a single batch to
avoid repeated disk I/O during list. Also guard against missing
status entries with fallback defaults.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-18 23:38:02 -07:00
3ba550d80a Fix stale in_review flag handling and review lifecycle
Move in_review flag set inside try block so finally always clears it,
and actively clear stale flags in list when Claude is no longer active.
Previously a crash between setting the flag and entering try would
leave the session stuck in review state.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-18 23:28:42 -07:00
bc102e416c Add in_review status to sessions and self-heal stale review flags
Review status now requires Claude to be active, preventing stale flags
from showing after a crash. Consolidates icon/color maps into a single
styles record and defers setting in_review until the container is up.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-18 23:16:06 -07:00
92dbad3cad Add review status tracking to sessions
The list command needs to show when a session is under active
review so users don't interrupt it. Wrapping the review body in
try/finally ensures the flag is always cleared on exit.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-18 23:08:41 -07:00
8172065928 0.0.38 2026-03-18 22:59:33 -07:00
da4b3a047e new version system 2026-03-18 22:59:28 -07:00
a35f16761a 0.0.37 2026-03-18 22:50:36 -07:00
2dea1d7df7 Merge branch 'active-bug' 2026-03-18 22:50:25 -07:00
1205249628 0.0.36 2026-03-18 22:36:08 -07:00
2ca978b728 Increase container memory limit from 4G to 32G 2026-03-18 22:36:04 -07:00
de48aeb02a Replace PostToolUseFailure hook with PreToolUse for activity tracking
PostToolUseFailure incorrectly marked the session idle on transient tool
errors. PreToolUse keeps the active signal fresh throughout tool execution,
while Stop alone handles the transition to idle.
2026-03-18 22:18:38 -07:00
48a06a2a79 0.0.35 2026-03-15 23:14:06 -07:00
97a6a2632a Improve commit message prompts and use Opus model 2026-03-15 23:13:40 -07:00
24ebdf4f5a Merge branch 'path' 2026-03-15 13:50:56 -07:00
b2694a3933 Add /sandlot/bin to container PATH 2026-03-15 13:50:50 -07:00
ec16a6722b Replace make with build-essential in package lists 2026-03-15 12:40:40 -07:00
8c1a01ba77 0.0.34 2026-03-15 09:34:36 -07:00
c68c9b5e0d Replace unzip with make in package list 2026-03-15 09:34:27 -07:00
b8c9603c71 Add musl target and cargo config for Rust 2026-03-15 09:24:27 -07:00
3c6cd05ef7 Add persistent Rust and Go tooling to container 2026-03-14 21:18:02 -07:00
c4c0703bee 0.0.33 2026-03-13 13:47:21 -07:00
90bb8da28e Add progress indicator to conflict resolution 2026-03-13 13:47:07 -07:00
53a426778d 0.0.32 2026-03-12 09:00:27 -07:00
4f487fe3ef Update sandlot-statusline to show cwd basename 2026-03-12 09:00:21 -07:00
65053976aa 0.0.31 2026-03-12 08:08:14 -07:00
51cc12596d Merge branch 'session-worktree' 2026-03-12 07:51:25 -07:00
3fc59774a5 refactor: extract installScript helper function 2026-03-12 07:45:16 -07:00
4b178dec44 enhance vm status with cross-repo session view 2026-03-11 22:42:54 -07:00
ac745d02f6 Add statusline script showing branch in powerline 2026-03-11 22:36:18 -07:00
aa1139c004 0.0.30 2026-03-11 22:14:20 -07:00
6d86a988f7 Track activity markers during merge/rebase 2026-03-11 22:13:55 -07:00
9994782748 0.0.29 2026-03-11 21:50:46 -07:00
8eabd31442 Use unique temp file names for Claude pipe 2026-03-11 21:50:43 -07:00
9c078ab2a4 0.0.28 2026-03-11 21:39:49 -07:00
fa45ea43ce Clear activity after session and on tool failure 2026-03-11 21:39:27 -07:00
3631411ce2 0.0.27 2026-03-11 21:27:06 -07:00
c07911bd70 Refactor review prompt for clarity 2026-03-11 21:25:41 -07:00
ee1bbd91d9 0.0.26 2026-03-11 14:40:19 -07:00
24981483a7 double dippin gone wrong 2026-03-11 14:39:59 -07:00
f0a692bb35 Add light/dark mode support to diff view 2026-03-11 14:36:25 -07:00
83787ab868 Add init and cd shell integration commands 2026-03-11 14:34:49 -07:00
4a465f7787 Improve review prompt 2026-03-11 14:09:47 -07:00