Merge pull request 'Add Gitea API error logging' (#24) from probablycorey/spike-error-debug into main

Reviewed-on: #24

packages/spike/src/gitea/api.ts

@@ -1,18 +1,33 @@
+import { log } from "../log"
 import type { Gitea } from "./types"
 
 const giteaUrl = "https://git.nose.space"
 
-export async function fetchPR(fullname: string, prNumber: number): Promise<Gitea.PullRequest> {
-  const url = `${giteaUrl}/api/v1/repos/${fullname}/pulls/${prNumber}`
+function tokenPrefix(): string {
+  const token = process.env.GITEA_API_TOKEN
+  if (!token) return "MISSING"
+  return `${token.slice(0, 4)}...${token.slice(-4)} (${token.length} chars)`
+}
+
+async function giteaFetch(url: string): Promise<Response> {
   const response = await fetch(url, {
     headers: {
       Authorization: `token ${process.env.GITEA_API_TOKEN}`,
     },
   })
+
   if (!response.ok) {
+    const body = await response.text()
+    log({ type: "gitea-api-error", status: response.status, url, body: body.slice(0, 500), tokenPrefix: tokenPrefix() })
     throw new Error(`Gitea API error: ${response.status} ${response.statusText}`)
   }
 
+  return response
+}
+
+export async function fetchPR(fullname: string, prNumber: number): Promise<Gitea.PullRequest> {
+  const url = `${giteaUrl}/api/v1/repos/${fullname}/pulls/${prNumber}`
+  const response = await giteaFetch(url)
   return response.json() as Promise<Gitea.PullRequest>
 }
 
@@ -20,16 +35,8 @@ export async function fetchReviewComments(
   fullname: string,
   prNumber: number
 ): Promise<Gitea.ReviewComment[]> {
-  // First, fetch all reviews
   const reviewsUrl = `${giteaUrl}/api/v1/repos/${fullname}/pulls/${prNumber}/reviews`
-  const reviewsResponse = await fetch(reviewsUrl, {
-    headers: {
-      Authorization: `token ${process.env.GITEA_API_TOKEN}`,
-    },
-  })
-  if (!reviewsResponse.ok) {
-    throw new Error(`Gitea API error: ${reviewsResponse.status} ${reviewsResponse.statusText}`)
-  }
+  const reviewsResponse = await giteaFetch(reviewsUrl)
 
   const reviews = (await reviewsResponse.json()) as Array<{
     id: number
@@ -40,21 +47,12 @@ export async function fetchReviewComments(
     comments_count: number
   }>
 
-  // For each review, fetch its comments
   const allComments: Gitea.ReviewComment[] = []
   for (const review of reviews) {
     if (review.comments_count === 0) continue
 
     const commentsUrl = `${giteaUrl}/api/v1/repos/${fullname}/pulls/${prNumber}/reviews/${review.id}/comments`
-    const commentsResponse = await fetch(commentsUrl, {
-      headers: {
-        Authorization: `token ${process.env.GITEA_API_TOKEN}`,
-      },
-    })
-
-    if (!commentsResponse.ok) {
-      throw new Error(`Gitea API error fetching review ${review.id} comments: ${commentsResponse.status} ${commentsResponse.statusText}`)
-    }
+    const commentsResponse = await giteaFetch(commentsUrl)
     const comments = (await commentsResponse.json()) as Gitea.ReviewComment[]
     allComments.push(...comments)
   }

packages/spike/src/log.ts

@@ -16,6 +16,7 @@ export type LogEvent =
   | { type: "crash-log-found" }
   | { type: "startup"; detail: string }
   | { type: "discord-ready" }
+  | { type: "gitea-api-error"; status: number; url: string; body: string; tokenPrefix: string }
   | { type: "error"; error: unknown; context?: string }
 
 export type StoredLogEvent = LogEvent & { ts: string }