probablycorey/shrimp
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Add comments to the tree #24

Merged
probablycorey merged 5 commits from comments-in-tree into main 2025-11-06 00:19:35 +00:00
Conversation 0 Commits 5 Files Changed 10 +156 -93
probablycorey commented 2025-11-05 18:31:32 +00:00
Owner
Copy Link
  1. Makes it so we can see the comments in the parse tree
  2. Requires that comments start with # instead of just #. Why? So we can create words with # in them. Is this a good idea? No clue, I don't feel strong about it, but I've been trying to let words be as weird as they want to be.
1. Makes it so we can see the comments in the parse tree 2. Requires that comments start with `# ` instead of just `#`. Why? So we can create words with # in them. Is this a good idea? No clue, I don't feel strong about it, but I've been trying to let words be as weird as they want to be.
probablycorey added 1 commit 2025-11-05 18:31:32 +00:00
probablycorey added 1 commit 2025-11-05 20:40:35 +00:00
defunkt reviewed 2025-11-05 21:10:38 +00:00
src/compiler/compiler.ts Outdated
@ -637,3 +658,3 @@
case terms.Array: {
const children = getAllChildren(node)
const children = getAllChildren(node).filter((n) => n.type.id !== terms.Comment)
defunkt commented 2025-11-05 21:10:38 +00:00
Owner
Copy Link

Maybe put the filter in getAllChildren() so we won't have to worry about it?

Maybe put the filter in getAllChildren() so we won't have to worry about it?
probablycorey commented 2025-11-05 22:51:07 +00:00
Author
Owner
Copy Link

YES

YES
probablycorey added 1 commit 2025-11-06 00:18:39 +00:00
probablycorey added 2 commits 2025-11-06 00:19:25 +00:00
probablycorey merged commit 7229f4afd0 into main 2025-11-06 00:19:35 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: probablycorey/shrimp#24
No description provided.
Delete Branch "comments-in-tree"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?