probablycorey/phone
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Move from polling to worker thread #3

Merged
probablycorey merged 7 commits from worker-test into main 2025-11-19 21:21:05 +00:00
Conversation 0 Commits 7 Files Changed 46 +1308 -693
probablycorey commented 2025-11-19 21:03:56 +00:00
Owner
Copy Link

I was polling for new pin events, but that felt icky. So now we check for events by blocking, but it is in a worker thread! Now all that libgpio magic is in once place and in a worker. Makes cleanup easy and does a good job encapsulating that hairy code.

It does make a new worker for each input, which is fine for how we are using it. But if we wanted like 20+ inputs we might want to have one worker and group all the inputs. This isn't hard, but it is more complex. Since we don't need it now I punted on it.

cc @probablycorey

I was polling for new pin events, but that felt icky. So now we check for events by blocking, but it is in a worker thread! Now all that libgpio magic is in once place and in a worker. Makes cleanup easy and does a good job encapsulating that hairy code. It *does* make a new worker for each input, which is fine for how we are using it. But if we wanted like 20+ inputs we might want to have one worker and group all the inputs. This isn't hard, but it is more complex. Since we don't need it now I punted on it. cc @probablycorey
probablycorey added 6 commits 2025-11-19 21:03:57 +00:00
probablycorey added 1 commit 2025-11-19 21:19:22 +00:00
probablycorey merged commit a5751b28f7 into main 2025-11-19 21:21:05 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: probablycorey/phone#3
No description provided.
Delete Branch "worker-test"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?