Commit Graph

97 Commits

Author SHA1 Message Date
727920c206 Change review status icon from ⦿ to ⊛
Improve visual distinction from the saved status icon (●)
2026-03-19 11:56:24 -07:00
2da22b940a Fix list command to skip empty JSON output and batch stale-review cleanup
Collapse redundant empty-session branch so --json falls through to the
normal serialization path instead of printing "[]" separately. Replace
per-branch load/save loop with a single state cycle to avoid racing
concurrent writes.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-19 11:29:22 -07:00
e8e5b850a0 Fix race conditions in state persistence by reading fresh session before writing
Batch-clearing stale flags in list and blindly writing back the session
in review could clobbер concurrent changes. Use per-session get/set
instead of whole-state load/save, and re-read before clearing in_review.
2026-03-19 11:24:18 -07:00
d10adac712 Replace patchSession with setSession to fix concurrent state writes
The fire-and-forget patchSession calls in list could race with each
other, each reading stale state before writing. Collecting stale
branches and doing a single load-modify-save eliminates the race.
Also emits valid JSON (`[]`) when listing with --json and no sessions.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-19 11:17:41 -07:00
9336deed9c Remove state file locking and simplify review cleanup
The mkdir-based lock was unreliable (stale lock recovery was racy) and
added latency. The atomic rename in save() already prevents corruption,
and concurrent writes to different keys are rare enough to not warrant
the complexity. Also inlines stale review self-healing into the map
callback and collapses the review try/catch/finally into just finally.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-19 11:11:16 -07:00
bd9d481e81 Add file-based locking to state mutations to prevent concurrent write races
Parallel operations (e.g. stale review cleanup in `list`) could
clobber each other via read-modify-write on the shared state file.
Also fix spinner lifecycle in `review` and simplify empty-list output.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-19 11:04:33 -07:00
69ba73b3c3 Use patchSession to avoid race conditions in review flag updates
The load-modify-save pattern could overwrite concurrent state changes.
patchSession does an atomic read-patch-write, and the list command now
re-checks activity before clearing stale flags to avoid racing with a
review that just started.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-19 10:56:50 -07:00
ad90c9dcc1 Fix race condition in stale review flag self-healing
Reload fresh state before saving to avoid overwriting concurrent changes
from other processes between the initial load and the heal write.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-19 10:47:20 -07:00
2f524da292 Fix stale review flag healing and prevent concurrent state overwrites
Use already-loaded state in list command instead of re-reading. In review
command, patch in_review on fresh state to avoid clobbering concurrent
changes, and skip worktree save in print mode. Remove unused white import
and unnecessary nullish coalescing fallback.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-18 23:55:49 -07:00
99f5a378f1 Fix stale in_review self-healing to run in JSON mode and update local objects before state load 2026-03-18 23:48:09 -07:00
a682539db3 Batch stale review-flag writes and fix review cleanup ordering
Move in_review flag set before try block so it is always visible,
and consolidate per-session state writes into a single batch to
avoid repeated disk I/O during list. Also guard against missing
status entries with fallback defaults.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-18 23:38:02 -07:00
3ba550d80a Fix stale in_review flag handling and review lifecycle
Move in_review flag set inside try block so finally always clears it,
and actively clear stale flags in list when Claude is no longer active.
Previously a crash between setting the flag and entering try would
leave the session stuck in review state.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-18 23:28:42 -07:00
bc102e416c Add in_review status to sessions and self-heal stale review flags
Review status now requires Claude to be active, preventing stale flags
from showing after a crash. Consolidates icon/color maps into a single
styles record and defers setting in_review until the container is up.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-18 23:16:06 -07:00
92dbad3cad Add review status tracking to sessions
The list command needs to show when a session is under active
review so users don't interrupt it. Wrapping the review body in
try/finally ensures the flag is always cleared on exit.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-18 23:08:41 -07:00
97a6a2632a Improve commit message prompts and use Opus model 2026-03-15 23:13:40 -07:00
90bb8da28e Add progress indicator to conflict resolution 2026-03-13 13:47:07 -07:00
4b178dec44 enhance vm status with cross-repo session view 2026-03-11 22:42:54 -07:00
6d86a988f7 Track activity markers during merge/rebase 2026-03-11 22:13:55 -07:00
fa45ea43ce Clear activity after session and on tool failure 2026-03-11 21:39:27 -07:00
c07911bd70 Refactor review prompt for clarity 2026-03-11 21:25:41 -07:00
24981483a7 double dippin gone wrong 2026-03-11 14:39:59 -07:00
f0a692bb35 Add light/dark mode support to diff view 2026-03-11 14:36:25 -07:00
83787ab868 Add init and cd shell integration commands 2026-03-11 14:34:49 -07:00
4a465f7787 Improve review prompt 2026-03-11 14:09:47 -07:00
56742224a5 Revert "Add stale worktree detection to list command"
This reverts commit 003c42bc03.
2026-03-11 13:57:27 -07:00
003c42bc03 Add stale worktree detection to list command 2026-03-11 13:31:19 -07:00
3438dddd5c Add git diff instruction to review prompt 2026-03-11 07:50:24 -07:00
1549ddc4e6 yup 2026-03-09 19:46:41 -07:00
5cc102ccdf four! 2026-03-09 19:45:21 -07:00
1f1b3f2a0d Track branch creation to avoid deleting pre-existing branches 2026-03-09 19:45:18 -07:00
6b5135c96e Fix worktree cleanup and dirty-check on branch move 2026-03-09 19:45:09 -07:00
e8318f68b0 Remove unused readdir import, simplify rmdir loop 2026-03-09 12:49:13 -07:00
385673f420 Refactor symlink removal into unlinkSessionSymlink helper 2026-03-09 12:04:04 -07:00
81dcac4097 Persist diff view toggle with localStorage 2026-03-08 22:21:43 -07:00
f0caf0b3fc Pass hljs to diff renderer call 2026-03-06 12:55:02 -08:00
2a37762aa5 Show new/deleted files as line-by-line diff 2026-03-06 08:32:51 -08:00
a808d2efbc Add unified/side-by-side toggle to diff view 2026-03-06 08:25:07 -08:00
e5e3a73cae whoops 2026-03-05 20:29:16 -08:00
b0ee848f39 this seems to work better 2026-03-05 07:39:28 -08:00
Chris Wanstrath
dc329ce446 new review 2026-03-04 13:49:40 -08:00
c2a082b780 Add optional prompt argument to review command 2026-03-01 21:04:03 -08:00
7e9d372d96 Show current branch name in merge success message 2026-02-27 07:59:46 -08:00
392d3c787b add --force flag to merge and squash commands 2026-02-27 07:48:21 -08:00
920b4d12b4 Add pre-merge validation in mergeAndClose 2026-02-27 07:45:09 -08:00
0cde238bc1 space 2026-02-27 07:34:01 -08:00
661e6f3450 Show VM not running warning in list 2026-02-27 07:31:45 -08:00
32da4e220f Add random branch name generation with word lists 2026-02-26 19:43:48 -08:00
0cd8443e2c Refactor checkout and add --force flag 2026-02-26 19:26:24 -08:00
7ebbfad8f2 Add ensureSession to recreate missing worktrees 2026-02-26 19:26:24 -08:00
c85af793cd Refactor teardown logic into shared helper 2026-02-26 19:26:24 -08:00