defunkt/sandlot
1
0
Fork 0
Code Pull Requests Activity

Add comment explaining why clearActivity is called before process.exit

Browse Source 
process.exit(1) skips the finally block, so cleanup must happen
explicitly in the catch block.
This commit is contained in:
Chris Wanstrath 2026-04-10 10:06:00 -07:00
parent 101651b107
commit a7285a4347
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/commands/helpers.ts
View File

@ -188,7 +188,7 @@ export async function mergeAndClose(branch: string, opts?: { squash?: boolean; f
} catch (err) { } catch (err) {
const message = err instanceof Error ? err.message : String(err) const message = err instanceof Error ? err.message : String(err)
spin.fail(message) spin.fail(message)
if (session) await vm.clearActivity(session.worktree, branch) if (session) await vm.clearActivity(session.worktree, branch) // process.exit below skips finally
await git.abortMerge(root) await git.abortMerge(root)
process.exit(1) process.exit(1)
} finally { } finally {